Conversation
Move apps/interface onto the workspace CCC packages so the UI can exercise the current preview, request, and collect flows without the old Lumos stack. Keep this as a preliminary migration by landing the new transaction wiring, failure handling, and local build setup first.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request performs a significant refactor of the iCKB interface, migrating from Lumos to the CCC (Common CKB Client) ecosystem and integrating the new @ickb/sdk monorepo packages. Key changes include updating the project structure, replacing legacy dependencies with workspace packages, and rewriting the transaction building and state management logic to use the new SDK. The review comment correctly identifies a potential infinite loop in the transaction status polling logic and provides an actionable suggestion to implement a retry limit or timeout.
Stop the CCC confirmation loop from waiting forever when a transaction never reaches a terminal state. Surface a timeout error instead so the interface can recover and the user gets a concrete failure message.
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request refactors the iCKB interface to transition from Lumos-based logic to the Common CKB Connector (CCC) and a new set of workspace packages (@ickb/core, @ickb/order, @ickb/sdk, @ickb/utils). Key changes include updated local development workflows, a restructured package.json for monorepo integration, and a complete overhaul of transaction building, wallet connection, and state querying logic. Review feedback identifies opportunities to improve error handling for wallet signers, remove redundant query invalidations and cell lock checks, and refactor transaction preview logic for better consistency.
Guard the JoyID signer lookup so the app fails with a concrete error when no CKB signer is available, and trim redundant refresh work in the confirmation path. Keep the exact cell search path direct by dropping a now-redundant lock equality recheck.
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request refactors the iCKB interface to transition from @ckb-lumos to the @ckb-ccc/ccc library and the new @ickb/* workspace packages (core, order, sdk, utils). Key changes include a complete rewrite of the transaction construction logic in transaction.ts, the migration of state management to @tanstack/react-query in queries.ts and App.tsx, and the implementation of CCC-native wallet connection in Connector.tsx. Additionally, the build system and README have been updated to support the monorepo structure and pnpm workspace filters. I have no feedback to provide as no review comments were submitted.
|
LGTM Phroi %123 |
1 participant
Why
The interface still depends on the old Lumos/v1 stack while the rest of the workspace has moved toward current CCC packages. This starts the migration in a safe preliminary form so we can review the new transaction wiring, query state handling, and local build setup before calling the interface migration complete.
Changes
apps/interfaceonto workspace@ickb/*CCC packages and remove the app-local lockfile